ArcsinX wrote:

> One side effect though: HLSLBufferDecl is also transparent, so cbuffer 
> members are now indexed too, which I think is correct, but happy to make it a 
> special case if not.

I am not familiar with HLSL, but I think the logic for all transparent contexts 
should be consistent: declarations inside them belong to the enclosing context. 
If this logic shouldn't apply to `HLSLBufferDecl`, it probably shouldn't have 
been marked transparent in the first place.

It seems we also need to check transparent context check 
[here](https://github.com/llvm/llvm-project/blob/main/clang/lib/UnifiedSymbolResolution/USRGeneration.cpp#L231)
 to ensure correct USR generation.

https://github.com/llvm/llvm-project/pull/234755
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to