dberris added inline comments.
================ Comment at: clang/lib/Driver/XRayArgs.cpp:32-33 constexpr char XRayNeverInstrumentOption[] = "-fxray-never-instrument="; +constexpr char XRayAlwaysEmitCustomEventsOption[] = + "-fxray-always-emit-customevents"; } // namespace ---------------- dblaikie wrote: > Not clear to me there's a benefit to having these defined as constants versus > using the literal directly - other parts of the driver use literals directly > & there's are mostly used just once? Good point. I was following the convention used in the SanitizerArgs implementation. I've moved the ones that haven't been repeated in this file in-line instead. https://reviews.llvm.org/D40601 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
