AdityaSinha149 wrote: > We should add a test for this change.
Thanks for the review. I added `DeviceOffloadHIPTest.DeviceObjectIsGenerated`. It parses a device function and checks that only the stub's "not supported yet" error is returned, so the new object generation step does not fail. Once the offload binary is generated, I'll replace it with a check of the embedded bundle, and the lit tests will cover the full flow on a GPU. https://github.com/llvm/llvm-project/pull/234498 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
