arphaman marked an inline comment as done. arphaman added inline comments.
================ Comment at: tools/libclang/CIndexer.cpp:131 + if (!File.empty()) + llvm::sys::fs::remove(File); +} ---------------- jkorous-apple wrote: > Just a thought - since we are not propagating errors from constructor we are > not really sure we were able to create the file in the first place (e. g. > return from ctor at line 103). Should we still try to delete it? If `createUniqueFile` failed in the constructor (return on line 103) then `File` will be empty. Therefore we won't try to remove the file. Repository: rC Clang https://reviews.llvm.org/D40527 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
