https://github.com/AlexVlx commented:
> IIUC, this PR removes all calls to `buildI32Constant`. Should we remove > `SPIRVInstructionSelector::buildI32Constant` from this file? We could. It is a slightly lighter interface which could perhaps be used when one knows they are in the entry block / and unambiguously dominating one, but that feels like a pretty narrow use case. https://github.com/llvm/llvm-project/pull/234291 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
