benedekaibas wrote: > Unfortunately your suggestion does not satisfy this,
Yes, you are right. > the one found by claude; This would be a small change in one commit. > the one that I describe here: > https://github.com/llvm/llvm-project/pull/225489#issuecomment-6317819900 This is a more complex change but if I do dedicated commits for it and nicely explain them in a comment that might help with following each step. Would this sound good to you? > maybe it is better if we switch roles: I create the PRs and you verify that > I'm not overlooking some corner case. If you disagree with my approach in this comment then we can go with this suggestion. I want to make sure that 1) we can follow through the reasoning on both sides 2) do not take more review time than needed from you and steakhal. And of course having a change that is correct. https://github.com/llvm/llvm-project/pull/225489 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
