https://github.com/yxsamliu approved this pull request.
LGTM. The earlier issues are fixed. Adding the HIP test in #231783 is reasonable. One small nit: please update the description to say the HIP constructor checks the AMDGPU target triple. https://github.com/llvm/llvm-project/pull/231391 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
