ayokunle321 wrote: > > > Can we test how this deduplication logic behaves with header units? I > > > believe the share the same code path but just to make sure this case is > > > covered for standard c++ modules. > > > > > > I can test this and let you know. Do you think it should be added as one of > > the tests in this PR? Or it would be repetitive since the clang modules one > > is already in > > A test or two wouldn’t hurt.
Added in [abdd847](https://github.com/llvm/llvm-project/pull/209795/commits/abdd847cc1144240d2e8f1c85480b6c829c0ebc9). They do dedup. https://github.com/llvm/llvm-project/pull/209795 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
