Wizard marked 4 inline comments as done.
Wizard added inline comments.

================
Comment at: clang-tidy/objc/CMakeLists.txt:4
 add_clang_library(clangTidyObjCModule
+  AvoidSpinlockCheck.cpp
   ForbiddenSubclassingCheck.cpp
----------------
benhamilton wrote:
> IMHO this is really a check which should apply to products built on Apple 
> SDKs, not for Objective-C.
> 
> I don't know if that means we should move this to an `apple` submodule or if 
> there is a better solution.
> 
> You don't have to move it in this review, but let's open up a discussion to 
> figure out where non-ObjC checks should go.
Sure. It would be a good time to move them when we have more `apple` checks 
like this.


https://reviews.llvm.org/D40325



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to