srhines added inline comments.
================
Comment at: lib/Driver/ToolChains/Gnu.cpp:660
+ // of a cpu flag.
+ Arg *A = Args.getLastArg(options::OPT_mcpu_EQ);
+ if (A) {
----------------
Is it better to sink A into the if condition again?
================
Comment at: test/Driver/as-mcpu.c:1
+// ================== Check that krait is substituted by cortex-15 when
invoking
+// the assembler
----------------
cortex-a15 - this is missing the "a".
================
Comment at: test/Driver/as-mcpu.c:6
+
+// ================== Check that kryo is substituted by cortex-57 when invoking
+// the assembler
----------------
cortex-a57
https://reviews.llvm.org/D40476
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
