Author: Mehdi Amini Date: 2026-10-11T17:05:30+02:00 New Revision: e1705375113c96e9ff74b387316609cce6127342
URL: https://github.com/llvm/llvm-project/commit/e1705375113c96e9ff74b387316609cce6127342 DIFF: https://github.com/llvm/llvm-project/commit/e1705375113c96e9ff74b387316609cce6127342.diff LOG: [docs] Update obsolete Phabricator references for GitHub workflows (#229542) Use GitHub pull requests in the contribution and code-review guidance, remove obsolete Phabricator contact handles and infrastructure listings, and update source links to their current locations. Assisted-by: Codex Added: Modified: clang/docs/ExternalClangExamples.md flang/docs/DesignGuideline.md libcxx/docs/Contributing.md libcxx/utils/ci/BOT_OWNERS.txt llvm/docs/CodeReview.md llvm/docs/Contributing.md llvm/docs/Proposals/VariableNames.rst llvm/docs/Proposals/VectorPredication.md llvm/docs/SupportPolicy.md Removed: ################################################################################ diff --git a/clang/docs/ExternalClangExamples.md b/clang/docs/ExternalClangExamples.md index 80e7f51cd3f89..91288d1c9e716 100644 --- a/clang/docs/ExternalClangExamples.md +++ b/clang/docs/ExternalClangExamples.md @@ -94,7 +94,7 @@ that can help developers, generally they must have code available. errors, fixit hints). See also [http://l.rw.rw/clang_plugin](http://l.rw.rw/clang_plugin) for step-by-step instructions." -[https://phabricator.kde.org/source/clazy](https://phabricator.kde.org/source/clazy) +[https://invent.kde.org/sdk/clazy](https://invent.kde.org/sdk/clazy) : "clazy is a compiler plugin which allows clang to understand Qt semantics. You get more than 50 Qt related compiler warnings, ranging from unneeded diff --git a/flang/docs/DesignGuideline.md b/flang/docs/DesignGuideline.md index 37e307a787878..10e26c72b626f 100644 --- a/flang/docs/DesignGuideline.md +++ b/flang/docs/DesignGuideline.md @@ -26,17 +26,18 @@ If several solutions can be considered, it is best to briefly describe the alternate solutions in 2) and why they were not retained. The design document should be added to the `docs` folder as a markdown document, -ideally using the name of the feature as the document name. Its approval on -Phabricator is the pre-requisite to submitting patches implementing new -features. +ideally using the name of the feature as the document name. Submit it as a +pull request to [LLVM on GitHub](https://github.com/llvm/llvm-project). Approval +of the design document is the prerequisite to submitting pull requests +implementing new features. An RFC on flang https://discourse.llvm.org can first be made as one sees fit, but this document should still be produced to summarize, organize, and formalize the discussions. If a related discourse RFC was made it is a good idea to give a link to it in the document for future reference. If no RFC was made before sending the design document for review, it is highly encouraged to make a small -announcement on https://discourse.llvm.org with a link to the Phabricator -design document review. +announcement on https://discourse.llvm.org with a link to the design document +pull request. The Testing Plan should briefly describe what aspects will be tested with LLVM unit test tools (see diff --git a/libcxx/docs/Contributing.md b/libcxx/docs/Contributing.md index 46d59b030802c..c19b3fc9b2002 100644 --- a/libcxx/docs/Contributing.md +++ b/libcxx/docs/Contributing.md @@ -118,18 +118,20 @@ sure you don't forget anything: ## The review process -After uploading your patch, you should see that the "libc++" review group is automatically -added as a reviewer for your patch. Once the group is marked as having approved your patch, -you can commit it. However, if you get an approval very quickly for a significant patch, -please try to wait a couple of business days before committing to give the opportunity for -other reviewers to chime in. If you need someone else to commit the patch for you, please -mention it and provide your `Name <email@domain>` for us to attribute the commit properly. - -Note that the rule for accepting as the "libc++" review group is to wait for two members -of the group to have approved the patch, excluding the patch author. This is not a hard -rule -- for very simple patches, use your judgement. The ["libc++" review group](https://reviews.llvm.org/project/members/64/) -consists of frequent libc++ contributors with a good understanding of the project's -guidelines -- if you would like to be added to it, please reach out on Discord. +Submit your change as a pull request to [LLVM on GitHub](https://github.com/llvm/llvm-project). +The `@llvm/reviewers-libcxx` team is automatically requested for review through +[CODEOWNERS](https://github.com/llvm/llvm-project/blob/main/.github/CODEOWNERS). +Once your pull request has the required approvals, you can merge it. However, if +you get an approval very quickly for a significant change, please try to wait a +couple of business days before merging to give other reviewers an opportunity to +chime in. If you need someone else to merge the pull request for you, please ask +explicitly and ensure your commits have the correct author name and email. + +Wait for two members of the libc++ review team to approve the pull request, +excluding the author. This is not a hard rule -- for very simple changes, +use your judgement. The review team consists of frequent libc++ contributors with +a good understanding of the project's guidelines -- if you would like to be added +to it, please reach out on Discord. Some tips: diff --git a/libcxx/utils/ci/BOT_OWNERS.txt b/libcxx/utils/ci/BOT_OWNERS.txt index f858fa775de44..31999cc4ae957 100644 --- a/libcxx/utils/ci/BOT_OWNERS.txt +++ b/libcxx/utils/ci/BOT_OWNERS.txt @@ -5,7 +5,7 @@ cannot be figured out by the community alone. The list is sorted by surname and formatted to allow easy grepping and beautification by scripts. The fields are: name (N), email (E), web-address (W), PGP key ID and fingerprint (P), description (D), snail-mail address -(S), Phabricator handle (H), and GitHub username(s) (G). +(S), and GitHub username(s) (G). Each entry should contain at least the (N), (E) and (D) fields. N: Linaro Toolchain Working Group diff --git a/llvm/docs/CodeReview.md b/llvm/docs/CodeReview.md index 343ea2acefd8e..e1d0311597a31 100644 --- a/llvm/docs/CodeReview.md +++ b/llvm/docs/CodeReview.md @@ -109,10 +109,8 @@ generally expected that suggested changes will be incorporated into a future revision of the patch unless the author and/or other reviewers can articulate a good reason to do otherwise (and then the reviewers must agree). If a new patch does not address all outstanding feedback, the author should explicitly state -that when providing the updated patch. When using the web-based code-review -tool, such notes can be provided in the "Diff" description (which is diff erent -from the description of the "Differential Revision" as a whole used for the -commit message). +that when updating the pull request. Such notes can be provided in a comment on +the pull request so reviewers can see which feedback remains outstanding. If you suggest changes in a code review, but don't wish the suggestion to be interpreted this strongly, please state so explicitly. diff --git a/llvm/docs/Contributing.md b/llvm/docs/Contributing.md index 8c75e4ff0da3c..6764dfffd5234 100644 --- a/llvm/docs/Contributing.md +++ b/llvm/docs/Contributing.md @@ -98,10 +98,9 @@ the git integration can be run from `clang/tools/clang-format/git-clang-format`. ::: -The LLVM project has migrated to GitHub Pull Requests as its review process. +The LLVM project uses GitHub Pull Requests for code review. For more information about the workflow of using GitHub Pull Requests see our -{ref}`GitHub <github-reviews>` documentation. We still have a read-only -[LLVM's Phabricator](https://reviews.llvm.org) instance. +{ref}`GitHub <github-reviews>` documentation. To make sure the right people see your patch, please select suitable reviewers and add them to your patch when requesting a review. diff --git a/llvm/docs/Proposals/VariableNames.rst b/llvm/docs/Proposals/VariableNames.rst index f092e98616b2b..2212cb7f7bb1a 100644 --- a/llvm/docs/Proposals/VariableNames.rst +++ b/llvm/docs/Proposals/VariableNames.rst @@ -8,7 +8,7 @@ intention of capturing the desires and concerns of the LLVM community, and forming them into a plan that can be agreed upon. The original author is somewhat naïve in the ways of LLVM so there will inevitably be some details that are flawed. You can help - you can edit this -page (preferably with a Phabricator review for larger changes) or reply to the +page by submitting a GitHub pull request or reply to the `Request For Comments thread <http://lists.llvm.org/pipermail/llvm-dev/2019-February/130083.html>`_. diff --git a/llvm/docs/Proposals/VectorPredication.md b/llvm/docs/Proposals/VectorPredication.md index d9667c9916537..992e092fe85c5 100644 --- a/llvm/docs/Proposals/VectorPredication.md +++ b/llvm/docs/Proposals/VectorPredication.md @@ -16,7 +16,7 @@ masked loads and stores, are available through intrinsics [^maskedir]. The Vector Predication (VP) extensions is a concrete RFC and prototype implementation to achieve native vector predication in LLVM. The VP prototype -and all related discussions can be found in the VP patch on Phabricator +and its original discussions are preserved in the archived code review [^vprfc]. ## Roadmap diff --git a/llvm/docs/SupportPolicy.md b/llvm/docs/SupportPolicy.md index 31903c45045b8..ec84bb62b2397 100644 --- a/llvm/docs/SupportPolicy.md +++ b/llvm/docs/SupportPolicy.md @@ -48,8 +48,7 @@ The core tier is composed of: compiler, debugger, linker, libraries, etc, including infrastructure code (table-gen, lit, file-check, unit-tests, etc). - Build infrastructure that creates releases and buildbots (CMake, scripts). - - [Phabricator](https://github.com/llvm/phabricator) and - [buildbot](https://github.com/llvm/llvm-zorg) infrastructure. + - [Buildbot](https://github.com/llvm/llvm-zorg) infrastructure. - The [test-suite](https://github.com/llvm/llvm-test-suite). ### Requirements _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
