saar.raz added inline comments.
================ Comment at: test/CXX/concepts-ts/expr/expr.prim/expr.prim.id/p3.cpp:1 +// RUN: %clang_cc1 -std=c++1z -fconcepts-ts -fcxx-exceptions -x c++ -verify %s +// expected-no-diagnostics ---------------- hubert.reinterpretcast wrote: > saar.raz wrote: > > Rakete1111 wrote: > > > There is no `-fconcepts-ts` flag AFAIK. Also, why `-fcxx-exceptions`, > > > it's not needed here. The `-x c++` part too. It should also be > > > `-std=c++2a`. > > There is a -fconcepts-ts flag (clang -Xclang -fconcepts-ts), I believe now > > that there is no more Concepts TS the flag should be removed as well and > > all concepts-related code be put under C++2a ifs. > This was discussed with Richard, Faisal, and Aaron Ballman before. We would > like to use -Xclang -fconcepts until there is enough of an implementation. > When we are ready, then we switch to having it directly under C++2a. There is > no reason why dealing with the option cannot be done as a separate patch, so > I don't think we need to hold up this one for that work. OK, wasn't aware this was discussed before. I agree then, leave the -fconcepts-ts for now. https://reviews.llvm.org/D40381 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
