sammccall edited reviewers, added: ioeric; removed: ilya-biryukov.
sammccall added a comment.

Oops, Eric is most likely to have this stuff in cache :-)
Sorry this is huge and ugly, -500 lines though!

I think the `Protocol` code could be a lot tighter (there's still a lot of 
repeated "is this an object", and "if this property exists parse it as type X 
and store it in field Y, else fail". (The kind of stuff YamlIO is good at).
I wanted to stick to a pretty literal translation first, and maybe later find a 
way to clean it up further. Hope that's OK!


https://reviews.llvm.org/D40406



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to