Sirraide wrote:

> > The assertion I think is a good addition too, but I feel like it should go 
> > in a separate patch, especially since apparently that’s causing issues 
> > elsewhere (possibly due to more missing lvalue-to-rvalue conversions).
> 
> I'm not sure what to do about the assertion in the string_view case above, 
> because `DefaultLvalueConversion` doesn't do anything in those cases, i.e. 
> where the lvalue is of struct type.

Right, you can’t do lvalue-to-rvalue conversion on class types... I’m not 
really that familiar w/ `asm` so I’m not sure what the best fix here would be

https://github.com/llvm/llvm-project/pull/227998
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to