sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clangd/ClangdUnit.h:51
 
+struct PreambleData;
+
----------------
can you move the definition here to avoid the extra decl?
(I tend to find this more readable and the struct is small, but if you prefer 
"top-down" that's fine too)


https://reviews.llvm.org/D40301



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to