Yes, r318830 has made our libcxx buildbots green. The public ones should become green as well.
Thanks, Evgeny -----Original Message----- From: Billy O'Neal <billy.on...@gmail.com> Date: Wednesday, 22 November 2017 at 12:30 To: Evgeny Astigeevich <evgeny.astigeev...@arm.com> Cc: "reviews+d40065+public+cdf4c853d41b4...@reviews.llvm.org" <reviews+d40065+public+cdf4c853d41b4...@reviews.llvm.org>, Billy Robert O'Neal III via Phabricator <revi...@reviews.llvm.org>, "e...@efcs.ca" <e...@efcs.ca>, "mclow.li...@gmail.com" <mclow.li...@gmail.com>, "cfe-commits@lists.llvm.org" <cfe-commits@lists.llvm.org>, nd <n...@arm.com> Subject: Re: [PATCH] D40065: [libcxx] [test] Change (void)s to TEST_IGNORE_NODISCARD as requested by Eric. OK, I think r318830 fixes the other one here. Thanks! Billy3 On Wed, Nov 22, 2017 at 4:25 AM, Billy O'Neal <billy.on...@gmail.com> wrote: > Sorry, I saw one bot fail and I thought I fixed it with > 37332d772480307af423fbea817c29a0832be86e but apparently there were > others I missed. > > On Wed, Nov 22, 2017 at 4:04 AM, Evgeny Astigeevich > <evgeny.astigeev...@arm.com> wrote: >> Hi Billy, >> >> These changes caused buildbot failures: tuple.by.type.fail.cpp Line 19: >> unknown type name 'TEST_IGNORE_NODISCARD' >> >> http://lab.llvm.org:8011/builders/libcxx-libcxxabi-x86_64-linux-ubuntu-cxx14/builds/1109 >> http://lab.llvm.org:8011/builders/libcxx-libcxxabi-x86_64-linux-ubuntu-cxx17/builds/1 >> http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-arm-linux/builds/924 >> http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-aarch64-linux/builds/972 >> >> Thanks, >> Evgeny Astigeevich >> >> >> -----Original Message----- >> From: cfe-commits <cfe-commits-boun...@lists.llvm.org> on behalf of Billy >> Robert O'Neal III via Phabricator via cfe-commits >> <cfe-commits@lists.llvm.org> >> Reply-To: "reviews+d40065+public+cdf4c853d41b4...@reviews.llvm.org" >> <reviews+d40065+public+cdf4c853d41b4...@reviews.llvm.org>, Billy Robert >> O'Neal III via Phabricator <revi...@reviews.llvm.org> >> Date: Tuesday, 21 November 2017 at 21:38 >> To: "billy.on...@gmail.com" <billy.on...@gmail.com>, "e...@efcs.ca" >> <e...@efcs.ca>, "mclow.li...@gmail.com" <mclow.li...@gmail.com> >> Cc: "cfe-commits@lists.llvm.org" <cfe-commits@lists.llvm.org> >> Subject: [PATCH] D40065: [libcxx] [test] Change (void)s to >> TEST_IGNORE_NODISCARD as requested by Eric. >> >> BillyONeal closed this revision. >> BillyONeal added a comment. >> >> Committed r318804 >> >> >> https://reviews.llvm.org/D40065 >> >> >> >> _______________________________________________ >> cfe-commits mailing list >> cfe-commits@lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >> >> _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
