https://github.com/chandlerc approved this pull request.
The return of `SmallString` doesn't worry me with modern C++ semantics -- it should get NRVO / RVO applied, and basically initialize in-place in the caller. LGTM with the code you have or with a tweaked version I mention if it doesn't regress performance. https://github.com/llvm/llvm-project/pull/227963 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
