AmrDeveloper wrote:

> This loses the NYIs, right? Are we sure this is the right way about this?

This now matches the same implementation in OGCG

https://github.com/llvm/llvm-project/blob/7e89fb5d646ef2d4b18520a8300818b5b94ef587/clang/lib/CodeGen/ItaniumCXXABI.cpp#L3671

The fields that I removed are now part of 

- `"clang/Basic/WebAssemblyReferenceTypes.def"`
- `"clang/Basic/HLSLIntangibleTypes.def"`

And no special handling for them

Those NYIs. I added them :D while upstreaming this part

https://github.com/llvm/llvm-project/pull/160002

This NYI is from the incubator

https://github.com/llvm/clangir/blob/63412d47b3d573ba2d7d55920541269930d4a303/clang/lib/CIR/CodeGen/CIRGenItaniumCXXABI.cpp#L1249-L1252

https://github.com/llvm/llvm-project/pull/227781
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to