mstorsjo added a comment.
No objection from me about committing this now, although I have some minor
comments (that possibly can be taken care of without reposting and
re-reviewing). Still ok with @rnk?
================
Comment at: lib/Frontend/InitPreprocessor.cpp:686
+ else if ((TI.getTriple().isThumb() || TI.getTriple().isARM()) &&
+ (TI.getTriple().isOSNetBSD() || TI.getTriple().isOSWindows()))
+ Builder.defineMacro("__ARM_DWARF_EH__");
----------------
I guess you could add an `|| LangOpts.DWARFExceptions` here as well? That would
allow you to manually enable dwarf on arm on linux as well. (I did that
manually while testing some bits in libunwind.)
Ideally I'd prefer to have a `UseDWARFExceptions` just like there already is
`UseSEHExceptions` and `UseSjLjExceptions` in the driver, so that it'd
explcitly pass `-fdwarf-exceptions` here in the cases where it's known to be
the default. But at least this form shouldn't break anything right now.
Repository:
rL LLVM
https://reviews.llvm.org/D39673
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
