https://github.com/tommat01 commented:

I'd like to understand a bit more about the motivation behind this, in order to 
know whether the loss in readability is worth it for the improved performance. 
I think it is relatively common for string tables to end up producing a lot of 
relocations in shared objects. Are there particular situations where the number 
of relocations is causing an issue? What percentage of the total is the 9kb, 
and does it have a noticeable effect on load time?

Could you not achieve the same result by changing the `StringRef` members to be 
`char [N]`?

https://github.com/llvm/llvm-project/pull/206937
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to