JDevlieghere added a comment.

I think you can achieve the same result with less code by checking for the 
flag's presence higher up, where currently `OPT_fsave_optimization_record` is 
handled (Clang.cpp:4329). Something like:

  if (Args.hasFlag(options::OPT_fsave_optimization_record,
                   options::OPT_fno_save_optimization_record, false) || 
      Args.hasFlag(options::OPT_foptimization_record_file_EQ, 
                   options::OPT_fno_save_optimization_record, false)) {

The test looks good to me.


https://reviews.llvm.org/D39834



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to