mgrang added a comment.

In https://reviews.llvm.org/D40234#929919, @ruiu wrote:

> Maybe we should do case-insensitive string comparison first, and if two 
> strings are considered the same, try again in case-sensitive manner? 
> Otherwise, even though the output is now deterministic, the output order is 
> still dependent on the order of input strings.


Thanks! I agree it's a better idea to use a stronger sort predicate. I have 
updated the patch accordingly.


https://reviews.llvm.org/D40234



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to