Eugene.Zelenko added a comment.

Does Fuchsia coding conventions allows default parameters in class methods? If 
not, test should reflect this



================
Comment at: docs/ReleaseNotes.rst:63
+
+  Prevent use of default arguments in declared or called functions in Fuchsia.
+
----------------
I think will be good idea to have description same as first sentence in 
documentation, i. e. //Warns if a function is declared or called with default 
arguments.//


================
Comment at: test/clang-tidy/fuchsia-default-arguments.cpp:6
+
+int f(void) {
+  foo();
----------------
Please remove //void// (see modernize-redundant-void-arg). Same below.


https://reviews.llvm.org/D40108



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to