rjmccall added inline comments.
================
Comment at: lib/Sema/SemaChecking.cpp:11661
if (Expr *capturer = findCapturingExpr(*this, msg->getArg(i), owner))
return diagnoseRetainCycle(*this, capturer, owner);
+ }
----------------
Failing to find a capturing expression will overwhelmingly be the controlling
condition here, so I would advise switching the order of the checks.
Otherwise, this patch looks good.
Repository:
rL LLVM
https://reviews.llvm.org/D40141
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
