ioeric added a comment. >> If the index action is already flexible enough, would you mind splitting the >> code for the index action out so that we can start reviewing it? Given that >> the current patch has very few tests, I guess it wouldn't be too much worse >> to split out the action without proper test. > > To clarify, the index action Nathan and I are referring to, is the indexing > action that exists currently in trunk and is the source of the index symbols, > feeding index symbols to an abstract `IndexDataConsumer`. See here: > https://llvm.org/svn/llvm-project/cfe/trunk/include/clang/Index/IndexingAction.h > This is what Marc used to get the index symbols and store them in his own > format. Tests for this functionality are in: > https://llvm.org/svn/llvm-project/cfe/trunk/test/Index/Core/
Ah, sorry, I was referring to `IndexRecordAction` and its friends (record readers/writers). I didn't notice the newly added index action added and really didn't mean to ask you to refactor the existing code. Apologies for the miscommunication! What I wanted to proposed is that we could decouple reading/writing of record/unit from the bit file format, so that the record output is not tied to a single output format (e.g. bit format, directory-based) and thus make the compiler more flexible. This might already be the case, but it's not really easy to tell from the current patch... https://reviews.llvm.org/D39050 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
