aaron.ballman added inline comments.
================ Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1595-1597 +def err_member_function_call_other : Error< + "cannot initialize object parameter of type %0 with an expression " + "of type %1">; ---------------- jtbandes wrote: > aaron.ballman wrote: > > I don't think this diagnostic needs to be moved and renamed; the old name > > was more clear than "other" on the new name. > How about `_bad_type`? I was hoping to give these all similar names since > they happen during the same implicit conversion. Also, while "implicit object > parameter" is technically a correct name, it seems to be not very commonly > used and would confuse users. Though it's also valuable for the diagnostic id > to be similar to the actual text... I'm not too worried about the identifier used for the diagnostic; it doesn't seem likely to confuse many people working on Clang (or at least, not confuse them for long). However, I wouldn't be opposed to `err_member_function_call_bad_type`. https://reviews.llvm.org/D39937 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
