arphaman added inline comments.
================ Comment at: lib/Tooling/Refactoring/Extract/CaptureVariables.h:36 + explicit CapturedExtractedEntity(const VarDecl *VD) + : Kind(CapturedVarDecl), VD(VD) {} + ---------------- ioeric wrote: > arphaman wrote: > > ioeric wrote: > > > Maybe a `FIXME` here for `Kind`? > > I think this constructor will always set the same kind. > Then why do you need `Kind`? Is it changed somewhere else? Please document > the behavior, The kind will be set to a different value by the other constructors that will be added later I added docs to the enum Repository: rL LLVM https://reviews.llvm.org/D39706 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits