Hahnfeld added a comment. In https://reviews.llvm.org/D39821#922026, @jakehehrlich wrote:
> In https://reviews.llvm.org/D39821#921703, @Hahnfeld wrote: > > > I think the current tests will only pass iff the executable name ends with > > `objcopy` - can we make this more reliable? > > > If I read the tests (split-debug.h, split-debug.c, and split-debug.s) > correctly they check for the existence of the word "objcopy" somewhere in the > executables name. I'm not sure how to make it anymore flexible than that. The > right thing to do would be to somehow get the string from CMake and use that > in this test. I'm not sure of llvm-lit supports any kind of find and replace > like that however. Right you are, I must have missed `{{.*}}` at the end. Another option would be to restrict `CLANG_DEFAULT_OBJCOPY` to contain `objcopy` or even to only allow `objcopy` or `llvm-objcopy`. I don't know if that's sensible though... Repository: rL LLVM https://reviews.llvm.org/D39821 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
