nicebert wrote: > I think the second commit should be reviewed as a separate PR, and get > reviews by Flang/MLIR contributors there.
I'd rather keep these together. The second commit builds directly on the lowering work in the first one and doesn't compile without it, and the flang, mlir and OpenMPIRBuilder parts of the first commit have to land together as well. Splitting it into two PRs is doable, it just turns this into a stack, and the clang work then can't land until the other one is reviewed and merged. Keeping it as two commits was meant to cover this, the flang/mlir change is separate so it can be reviewed on its own without splitting the PR. None of that side was the goal here either, it came out of the no-loop investigation on the clang side, those were the gaps in the shared lowering that no-loop needs closed. Since the PR already has the flang and mlir labels, could the reviewers there just look at commit 1 in place? https://github.com/llvm/llvm-project/pull/205325 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
