================ @@ -0,0 +1,34 @@ +#ifndef LLVM_TRANSFORMS_UTILS_SPLITMODULECG_H ---------------- mmjjpp wrote:
Good point — I agree that externalize() and the surrounding invocation loops are duplicated between SplitModule.cpp and SplitModuleCG.cpp, and refactoring them into a shared facility would reduce duplication. Based on your experience with LLVM's review process, would a follow-up refactoring PR be more appropriate here? The current PR is already fairly large with the review-driven changes, and the refactoring would touch SplitModule.cpp (which this PR doesn't currently modify), so a separate PR might keep the scope cleaner. But I'm happy to do either — let me know what you think. https://github.com/llvm/llvm-project/pull/198702 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
