ABataev added inline comments.
================
Comment at: lib/Sema/SemaExpr.cpp:14356
+ if (S.IsOpenMPCapturedDecl(Var)) {
+ bool hasConst = DeclRefType.isConstQualified();
DeclRefType = DeclRefType.getUnqualifiedType();
----------------
`hasConst` must start from capital letter `HasConst`.
================
Comment at: lib/Sema/SemaExpr.cpp:14360
+ if (hasConst)
+ DeclRefType = QualType(DeclRefType.getTypePtr(), Qualifiers::Const);
+ }
----------------
Better to make it this way:
```
DeclRefType.addConst();
```
================
Comment at: test/OpenMP/parallel_firstprivate_messages.cpp:75
#pragma omp parallel firstprivate (a, b, c, d, f) // expected-error
{{firstprivate variable with incomplete type 'S1'}}
+ d = 5; // expected-error {{cannot assign to variable 'd' with
const-qualified type}}
#pragma omp parallel firstprivate (argv[1]) // expected-error {{expected
variable name}}
----------------
Please, add a separate directive with this assignment
https://reviews.llvm.org/D39859
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
