================
@@ -696,15 +712,17 @@ Value *CodeGenFunction::EmitHLSLBuiltinExpr(unsigned 
BuiltinID,
     Args.push_back(HandleOp);
     Args.push_back(SamplerOp);
     Args.push_back(CoordOp);
-    Args.push_back(emitHlslOffset(*this, E, 3, getOffsetType(CGM, RT)));
+    const unsigned OffsetIdx = 3;
+    Args.push_back(emitHlslSampleOffset(*this, E, RT, OffsetIdx));
 
     llvm::Type *RetTy = ConvertType(E->getType());
-    if (E->getNumArgs() <= 4) {
+    const unsigned ClampIdx = getHlslClampArgIndex(RT, OffsetIdx);
+    if (E->getNumArgs() <= ClampIdx) {
       return EmitIntrinsicCall(CGM.getHLSLRuntime().getSampleIntrinsic(), Args,
                                RetTy);
     }
----------------
hekota wrote:

```suggestion
    constexpr unsigned ClampIdx = getHlslClampArgIndex(RT, OffsetIdx);
    if (E->getNumArgs() <= ClampIdx)
      return EmitIntrinsicCall(CGM.getHLSLRuntime().getSampleIntrinsic(), Args,
RetTy);
```
Same here, and there are extra brackets.

https://github.com/llvm/llvm-project/pull/218520
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to