sammccall added a comment. In https://reviews.llvm.org/D39836#920306, @ilya-biryukov wrote:
> I personally think they're useful to have anyway, and they don't add much > noise when they're at the end of completions list. > I sometimes want to complete an item I know is there and then fix > accessibility. Do you think they add too much noise? For me the noise definitely outweighs the value, e.g. when I'm trying to see all the available functions. There are costs beyond noise: - they bulk up tests and debugging output - they complicate the scoring scheme - we *never* want them to appear above a legal completion, so a 1-dimensional score needs special handling as here. - compute: we spend time scoring them, computing their strings, writing them over the wire, and then the client has to process them https://reviews.llvm.org/D39836 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
