hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land.
The code looks good to me. > I did not find any existing tests. Yeah, we don't have good test strategy for these py files. We normally verify them by running them locally. I think we can land it as long as you test it locally (would be better to describe how you test it in the commit message). ================ Comment at: clang-tidy/tool/run-clang-tidy.py:232 + files = [make_absolute(entry['file'], entry['directory']) + for entry in database] ---------------- nit: the code indention seems wrong here. https://reviews.llvm.org/D39603 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
