================
@@ -128,15 +128,14 @@ GlobalVariable *offloading::emitOffloadingEntry(
   return Entry;
 }
 
-std::pair<GlobalVariable *, GlobalVariable *>
-offloading::getOffloadEntryArray(Module &M) {
+std::pair<Constant *, Constant *> offloading::getOffloadEntryArray(Module &M) {
   const llvm::Triple &Triple = M.getTargetTriple();
   StringRef SectionName = getOffloadEntrySection(M);
 
-  auto *ZeroInitilaizer =
-      ConstantAggregateZero::get(ArrayType::get(getEntryTy(M), 0u));
-  auto *EntryInit = Triple.isOSBinFormatCOFF() ? ZeroInitilaizer : nullptr;
-  auto *EntryType = ArrayType::get(getEntryTy(M), 0);
+  auto *ZeroInitializer = ConstantAggregateZero::get(
----------------
jhuber6 wrote:

Was just wondering, because I know that it's basically a `begin != end` 
iteration and for ELF I think we specifically have logic that skips the 'dummy' 
entry, which IIRC was just due to the entry being zeroed? Was curious why we 
needed to change the initializer, but i might be reading it wrong.

https://github.com/llvm/llvm-project/pull/215390
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to