llvmorg-github-actions[bot] wrote:

<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang

Author: Erich Keane (erichkeane)

<details>
<summary>Changes</summary>

These are effectively irrelevant, as the problem we are trying to check for is 
that the app doesn't crash. So make them a bit more specific (add 'acc ') since 
we don't know what any sort of IR for these would look like ANYWAY.  Hopefully 
the higher specificity makes these good enough for folks.

---
Full diff: https://github.com/llvm/llvm-project/pull/215677.diff


1 Files Affected:

- (modified) clang/test/CodeGen/openacc-invalid-stmt.cpp (+9-6) 


``````````diff
diff --git a/clang/test/CodeGen/openacc-invalid-stmt.cpp 
b/clang/test/CodeGen/openacc-invalid-stmt.cpp
index faad429aa0c4d..337e35c19c36e 100644
--- a/clang/test/CodeGen/openacc-invalid-stmt.cpp
+++ b/clang/test/CodeGen/openacc-invalid-stmt.cpp
@@ -1,24 +1,27 @@
 // RUN: %clang_cc1 %s -emit-llvm -o - | FileCheck %s
 // CHECK: target triple
+// Note: the original bug was just that the test asserted
+// because it attempted to emit an empty statement, so check-lines
+// are effectively irrelevant, but included for completeness.
 
 void foo() {
 #pragma acc parallel
   _Alignas(4);
-  // CHECK-NOT: parallel
+  // CHECK-NOT: acc parallel
 #pragma acc loop
   _Alignas(4);
-  // CHECK-NOT: loop
+  // CHECK-NOT: acc loop
 #pragma acc kernels loop
   _Alignas(4);
-  // CHECK-NOT: kernels
+  // CHECK-NOT: acc kernels
 #pragma acc data
   _Alignas(4);
-  // CHECK-NOT: data 
+  // CHECK-NOT: acc data
 #pragma acc host_data
   _Alignas(4);
-  // CHECK-NOT: host 
+  // CHECK-NOT: acc host
 #pragma acc atomic
   _Alignas(4);
-  // CHECK-NOT: atomic 
+  // CHECK-NOT: acc atomic
 }
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/215677
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to