iitianpushkar wrote: > I think we might be missing a test where we take the `unnamed` branch for the > reporting. > > But overall it looks great for me. Once @NeKon69 is also happy with the PR, I > think we can merge this. > > I know we asked for a lot of changes and iterations and sometimes my comments > were not the clearest. Thanks a lot for sticking around and putting in the > hard work, this is a great improvement for the readability of the diagnostics!
Ok, I will also add a test for `unnamed` branch in the next updated patch. Also, thanks a lot for reviewing and guiding. Learnt a lot about code design in this PR. https://github.com/llvm/llvm-project/pull/206337 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
