================ ---------------- kikairoya wrote:
(assuming https://github.com/llvm/llvm-project/pull/147960/changes#r3743109655 is replying to here) I'm talking about `// CHECK-...: "--disable-high-entropy-va"`. ``` +// CHECK-64: "{{.*}}ld{{(\.exe)?}}" +// CHECK-64-SAME: "-m" "i386pep" +// CHECK-64-SAME: "{{.*}}{{/|\\\\}}crt0.o" +// CHECK-64-SAME: "{{.*}}x86_64-pc-msys{{/|\\\\}}{{[0-9.]*}}{{/|\\\\}}crtbegin.o" +// CHECK-64-SAME: "--disable-high-entropy-va" <-------------------------------- THIS +// CHECK-64-SAME: "{{.*}}x86_64-pc-msys{{/|\\\\}}{{[0-9.]*}}{{/|\\\\}}crtend.o" ``` ``` +// CHECK-64-ASLR-DEFAULT: "{{.*}}ld{{(\.exe)?}}" +// CHECK-64-ASLR-DEFAULT-SAME: "--disable-high-entropy-va" <----- AND THIS +// CHECK-64-ASLR-DEFAULT-SAME: "--disable-nxcompat" ``` Why is `--disable-high-entropy-va` needed in CHECK-64, especially since `--disable-nxcompat`, which is paired in `CHECK-64-ASLR-DEFAULT,` isn't checked? https://github.com/llvm/llvm-project/pull/147960 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
