================
@@ -36,12 +37,12 @@ using ThreadState = llvm::offload::ThreadStateTy;
 Error_t Malloc(void **DevPtr, size_t Size) {
   ol_device_handle_t Device = ThreadState::getDefaultDevice();
   ol_result_t Result = olMemAlloc(Device, OL_ALLOC_TYPE_DEVICE, Size, DevPtr);
-  return convertResult(Result);
+  return SetLastError(convertResult(Result));
 }
 
 Error_t Free(void *DevPtr) {
   ol_result_t Result = olMemFree(DevPtr);
-  return convertResult(Result);
+  return SetLastError(convertResult(Result));
----------------
kevinsala wrote:

I see many cases like `SetLastError(convertResult(Result))`. Would it be worth 
adding an overloaded function that accepts the ol_result_t and converts it 
directly?

https://github.com/llvm/llvm-project/pull/213389
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to