https://github.com/NagyDonat commented:

Thanks for the update!

I reviewed the body of `getContainerOfParentRegion` and it seems to be correct. 
I suggested a few opportunities for simplifications in inline comments, but 
overall I'm satisfied with the code quality.

I'll review the rest of the PR (the helper functions and the tests) tomorrow.

I also invite the other maintainers of the static analyzer as reviewers, to let 
them also add their suggestions if they want to.

https://github.com/llvm/llvm-project/pull/214140
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to