llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang-tidy Author: Baranov Victor (vbvictor) <details> <summary>Changes</summary> --- Patch is 29.71 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/213840.diff 28 Files Affected: - (modified) clang-tools-extra/clang-tidy/abseil/AbseilMatcher.h (+1-1) - (modified) clang-tools-extra/clang-tidy/abseil/CleanupCtadCheck.cpp (+3-2) - (modified) clang-tools-extra/clang-tidy/abseil/DurationComparisonCheck.cpp (+4-4) - (modified) clang-tools-extra/clang-tidy/abseil/DurationConversionCastCheck.cpp (+1-1) - (modified) clang-tools-extra/clang-tidy/abseil/DurationRewriter.cpp (+3-3) - (modified) clang-tools-extra/clang-tidy/abseil/DurationUnnecessaryConversionCheck.cpp (+1-1) - (modified) clang-tools-extra/clang-tidy/abseil/FasterStrsplitDelimiterCheck.cpp (+1-1) - (modified) clang-tools-extra/clang-tidy/abseil/StringFindStartswithCheck.cpp (+6-6) - (modified) clang-tools-extra/clang-tidy/abseil/StringFindStrContainsCheck.cpp (+6-6) - (modified) clang-tools-extra/clang-tidy/abseil/TimeComparisonCheck.cpp (+1-1) - (modified) clang-tools-extra/clang-tidy/abseil/TimeSubtractionCheck.cpp (+3-3) - (modified) clang-tools-extra/clang-tidy/abseil/UncheckedStatusOrAccessCheck.cpp (+1-1) - (modified) clang-tools-extra/clang-tidy/altera/IdDependentBackwardBranchCheck.cpp (+2-2) - (modified) clang-tools-extra/clang-tidy/altera/SingleWorkItemBarrierCheck.cpp (+1-1) - (modified) clang-tools-extra/clang-tidy/altera/StructPackAlignCheck.cpp (+1-1) - (modified) clang-tools-extra/clang-tidy/android/CloexecAccept4Check.cpp (+3-2) - (modified) clang-tools-extra/clang-tidy/android/CloexecAcceptCheck.cpp (+3-2) - (modified) clang-tools-extra/clang-tidy/android/CloexecCreatCheck.cpp (+2-2) - (modified) clang-tools-extra/clang-tidy/android/CloexecFopenCheck.cpp (+1-1) - (modified) clang-tools-extra/clang-tidy/android/CloexecMemfdCreateCheck.cpp (+1-1) - (modified) clang-tools-extra/clang-tidy/android/CloexecOpenCheck.cpp (+1-1) - (modified) clang-tools-extra/clang-tidy/boost/UseToStringCheck.cpp (+3-3) - (modified) clang-tools-extra/clang-tidy/custom/QueryCheck.cpp (+5-4) - (modified) clang-tools-extra/clang-tidy/google/AvoidThrowingObjCExceptionCheck.cpp (+4-3) - (modified) clang-tools-extra/clang-tidy/google/GlobalVariableDeclarationCheck.cpp (+3-2) - (modified) clang-tools-extra/clang-tidy/google/IntegerTypesCheck.cpp (+3-3) - (modified) clang-tools-extra/clang-tidy/google/UpgradeGoogletestCaseCheck.cpp (+5-5) - (modified) clang-tools-extra/clang-tidy/linuxkernel/MustCheckErrsCheck.cpp (+5-4) ``````````diff diff --git a/clang-tools-extra/clang-tidy/abseil/AbseilMatcher.h b/clang-tools-extra/clang-tidy/abseil/AbseilMatcher.h index 86746bfac0257..3f24603988801 100644 --- a/clang-tools-extra/clang-tidy/abseil/AbseilMatcher.h +++ b/clang-tools-extra/clang-tidy/abseil/AbseilMatcher.h @@ -33,7 +33,7 @@ namespace clang::ast_matchers { AST_POLYMORPHIC_MATCHER( isInAbseilFile, AST_POLYMORPHIC_SUPPORTED_TYPES(Decl, Stmt, TypeLoc, NestedNameSpecifierLoc)) { - auto &SourceManager = Finder->getASTContext().getSourceManager(); + const auto &SourceManager = Finder->getASTContext().getSourceManager(); const SourceLocation Loc = SourceManager.getSpellingLoc(Node.getBeginLoc()); if (Loc.isInvalid()) return false; diff --git a/clang-tools-extra/clang-tidy/abseil/CleanupCtadCheck.cpp b/clang-tools-extra/clang-tidy/abseil/CleanupCtadCheck.cpp index dd20ad8a4c269..7053309dd26f8 100644 --- a/clang-tools-extra/clang-tidy/abseil/CleanupCtadCheck.cpp +++ b/clang-tools-extra/clang-tidy/abseil/CleanupCtadCheck.cpp @@ -19,8 +19,9 @@ using namespace ::clang::transformer; namespace clang::tidy::abseil { static RewriteRuleWith<std::string> cleanupCtadCheckImpl() { - auto WarningMessage = cat("prefer absl::Cleanup's class template argument " - "deduction pattern in C++17 and higher"); + const auto WarningMessage = + cat("prefer absl::Cleanup's class template argument " + "deduction pattern in C++17 and higher"); return makeRule( declStmt(hasSingleDecl(varDecl( diff --git a/clang-tools-extra/clang-tidy/abseil/DurationComparisonCheck.cpp b/clang-tools-extra/clang-tidy/abseil/DurationComparisonCheck.cpp index f00877754f952..c2dce68b4569e 100644 --- a/clang-tools-extra/clang-tidy/abseil/DurationComparisonCheck.cpp +++ b/clang-tools-extra/clang-tidy/abseil/DurationComparisonCheck.cpp @@ -16,10 +16,10 @@ using namespace clang::ast_matchers; namespace clang::tidy::abseil { void DurationComparisonCheck::registerMatchers(MatchFinder *Finder) { - auto Matcher = expr(comparisonOperatorWithCallee(functionDecl( - functionDecl(durationConversionFunction()) - .bind("function_decl")))) - .bind("binop"); + const auto Matcher = expr(comparisonOperatorWithCallee(functionDecl( + functionDecl(durationConversionFunction()) + .bind("function_decl")))) + .bind("binop"); Finder->addMatcher(Matcher, this); } diff --git a/clang-tools-extra/clang-tidy/abseil/DurationConversionCastCheck.cpp b/clang-tools-extra/clang-tidy/abseil/DurationConversionCastCheck.cpp index ae2cf5b4cb642..77601b3c2d700 100644 --- a/clang-tools-extra/clang-tidy/abseil/DurationConversionCastCheck.cpp +++ b/clang-tools-extra/clang-tidy/abseil/DurationConversionCastCheck.cpp @@ -18,7 +18,7 @@ using namespace clang::ast_matchers; namespace clang::tidy::abseil { void DurationConversionCastCheck::registerMatchers(MatchFinder *Finder) { - auto CallMatcher = ignoringImpCasts(callExpr( + const auto CallMatcher = ignoringImpCasts(callExpr( callee(functionDecl(durationConversionFunction()).bind("func_decl")), hasArgument(0, expr().bind("arg")))); diff --git a/clang-tools-extra/clang-tidy/abseil/DurationRewriter.cpp b/clang-tools-extra/clang-tidy/abseil/DurationRewriter.cpp index 035e7d642c8b7..388b3b71baf43 100644 --- a/clang-tools-extra/clang-tidy/abseil/DurationRewriter.cpp +++ b/clang-tools-extra/clang-tidy/abseil/DurationRewriter.cpp @@ -111,7 +111,7 @@ StringRef getTimeInverseForScale(DurationScale Scale) { /// Returns `true` if `Node` is a value which evaluates to a literal `0`. bool isLiteralZero(const MatchFinder::MatchResult &Result, const Expr &Node) { - auto ZeroMatcher = + const auto ZeroMatcher = anyOf(integerLiteral(equals(0)), floatLiteral(equals(0.0))); // Check to see if we're using a zero directly. @@ -196,7 +196,7 @@ std::optional<DurationScale> getScaleForDurationInverse(StringRef Name) { {"ToDoubleNanoseconds", DurationScale::Nanoseconds}, {"ToInt64Nanoseconds", DurationScale::Nanoseconds}}); - auto ScaleIter = ScaleMap.find(Name); + const auto ScaleIter = ScaleMap.find(Name); if (ScaleIter == ScaleMap.end()) return std::nullopt; @@ -212,7 +212,7 @@ std::optional<DurationScale> getScaleForTimeInverse(StringRef Name) { {"ToUnixMicros", DurationScale::Microseconds}, {"ToUnixNanos", DurationScale::Nanoseconds}}); - auto ScaleIter = ScaleMap.find(Name); + const auto ScaleIter = ScaleMap.find(Name); if (ScaleIter == ScaleMap.end()) return std::nullopt; diff --git a/clang-tools-extra/clang-tidy/abseil/DurationUnnecessaryConversionCheck.cpp b/clang-tools-extra/clang-tidy/abseil/DurationUnnecessaryConversionCheck.cpp index 5867fb630315d..9e11d262b5290 100644 --- a/clang-tools-extra/clang-tidy/abseil/DurationUnnecessaryConversionCheck.cpp +++ b/clang-tools-extra/clang-tidy/abseil/DurationUnnecessaryConversionCheck.cpp @@ -27,7 +27,7 @@ void DurationUnnecessaryConversionCheck::registerMatchers(MatchFinder *Finder) { // Matcher which matches the current scale's factory with a `1` argument, // e.g. `absl::Seconds(1)`. - auto FactoryMatcher = ignoringElidableConstructorCall( + const auto FactoryMatcher = ignoringElidableConstructorCall( callExpr(callee(functionDecl(hasName(DurationFactory))), hasArgument(0, ignoringImpCasts(integerLiteral(equals(1)))))); diff --git a/clang-tools-extra/clang-tidy/abseil/FasterStrsplitDelimiterCheck.cpp b/clang-tools-extra/clang-tidy/abseil/FasterStrsplitDelimiterCheck.cpp index 391777225f739..e6ac0b5308398 100644 --- a/clang-tools-extra/clang-tidy/abseil/FasterStrsplitDelimiterCheck.cpp +++ b/clang-tools-extra/clang-tidy/abseil/FasterStrsplitDelimiterCheck.cpp @@ -62,7 +62,7 @@ void FasterStrsplitDelimiterCheck::registerMatchers(MatchFinder *Finder) { // Binds to a string_view (either absl or std) that was passed by value and // constructed from string literal. - auto StringViewArg = ignoringElidableConstructorCall(ignoringImpCasts( + const auto StringViewArg = ignoringElidableConstructorCall(ignoringImpCasts( cxxConstructExpr(hasType(recordDecl(hasName("::absl::string_view"))), hasArgument(0, ignoringParenImpCasts(SingleChar))))); diff --git a/clang-tools-extra/clang-tidy/abseil/StringFindStartswithCheck.cpp b/clang-tools-extra/clang-tidy/abseil/StringFindStartswithCheck.cpp index e1063c4f8a46e..5bd328a3cc7af 100644 --- a/clang-tools-extra/clang-tidy/abseil/StringFindStartswithCheck.cpp +++ b/clang-tools-extra/clang-tidy/abseil/StringFindStartswithCheck.cpp @@ -34,12 +34,12 @@ StringFindStartswithCheck::StringFindStartswithCheck(StringRef Name, Options.get("AbseilStringsMatchHeader", "absl/strings/match.h")) {} void StringFindStartswithCheck::registerMatchers(MatchFinder *Finder) { - auto ZeroLiteral = integerLiteral(equals(0)); - auto StringClassMatcher = cxxRecordDecl(hasAnyName(StringLikeClasses)); - auto StringType = hasUnqualifiedDesugaredType( + const auto ZeroLiteral = integerLiteral(equals(0)); + const auto StringClassMatcher = cxxRecordDecl(hasAnyName(StringLikeClasses)); + const auto StringType = hasUnqualifiedDesugaredType( recordType(hasDeclaration(StringClassMatcher))); - auto StringFind = cxxMemberCallExpr( + const auto StringFind = cxxMemberCallExpr( // .find()-call on a string... callee(cxxMethodDecl(hasName("find")).bind("findfun")), on(hasType(StringType)), @@ -57,7 +57,7 @@ void StringFindStartswithCheck::registerMatchers(MatchFinder *Finder) { .bind("expr"), this); - auto StringRFind = cxxMemberCallExpr( + const auto StringRFind = cxxMemberCallExpr( // .rfind()-call on a string... callee(cxxMethodDecl(hasName("rfind")).bind("findfun")), on(hasType(StringType)), @@ -110,7 +110,7 @@ void StringFindStartswithCheck::check(const MatchFinder::MatchResult &Result) { const bool Neg = ComparisonExpr->getOpcode() == BO_NE; // Create the warning message and a FixIt hint replacing the original expr. - auto Diagnostic = + const auto Diagnostic = diag(ComparisonExpr->getBeginLoc(), "use %select{absl::StartsWith|!absl::StartsWith}0 " "instead of %select{find()|rfind()}1 %select{==|!=}0 0") diff --git a/clang-tools-extra/clang-tidy/abseil/StringFindStrContainsCheck.cpp b/clang-tools-extra/clang-tidy/abseil/StringFindStrContainsCheck.cpp index 5b31c002fce2b..e02263a81f47e 100644 --- a/clang-tools-extra/clang-tidy/abseil/StringFindStrContainsCheck.cpp +++ b/clang-tools-extra/clang-tidy/abseil/StringFindStrContainsCheck.cpp @@ -42,15 +42,15 @@ static constexpr char DefaultAbseilStringsMatchHeader[] = static transformer::RewriteRuleWith<std::string> makeRewriteRule(ArrayRef<StringRef> StringLikeClassNames, StringRef AbseilStringsMatchHeader) { - auto StringLikeClass = cxxRecordDecl(hasAnyName(StringLikeClassNames)); - auto StringType = + const auto StringLikeClass = cxxRecordDecl(hasAnyName(StringLikeClassNames)); + const auto StringType = hasUnqualifiedDesugaredType(recordType(hasDeclaration(StringLikeClass))); - auto CharStarType = + const auto CharStarType = hasUnqualifiedDesugaredType(pointerType(pointee(isAnyCharacter()))); - auto CharType = hasUnqualifiedDesugaredType(isCharType()); - auto StringNpos = declRefExpr( + const auto CharType = hasUnqualifiedDesugaredType(isCharType()); + const auto StringNpos = declRefExpr( to(varDecl(hasName("npos"), hasDeclContext(StringLikeClass)))); - auto StringFind = cxxMemberCallExpr( + const auto StringFind = cxxMemberCallExpr( callee(cxxMethodDecl( hasName("find"), parameterCountIs(2), hasParameter( diff --git a/clang-tools-extra/clang-tidy/abseil/TimeComparisonCheck.cpp b/clang-tools-extra/clang-tidy/abseil/TimeComparisonCheck.cpp index 5d80b16239838..7f3bc9b783308 100644 --- a/clang-tools-extra/clang-tidy/abseil/TimeComparisonCheck.cpp +++ b/clang-tools-extra/clang-tidy/abseil/TimeComparisonCheck.cpp @@ -16,7 +16,7 @@ using namespace clang::ast_matchers; namespace clang::tidy::abseil { void TimeComparisonCheck::registerMatchers(MatchFinder *Finder) { - auto Matcher = + const auto Matcher = expr(comparisonOperatorWithCallee(functionDecl( functionDecl(timeConversionFunction()).bind("function_decl")))) .bind("binop"); diff --git a/clang-tools-extra/clang-tidy/abseil/TimeSubtractionCheck.cpp b/clang-tools-extra/clang-tidy/abseil/TimeSubtractionCheck.cpp index b7d5cf69fdf68..e93bd54921430 100644 --- a/clang-tools-extra/clang-tidy/abseil/TimeSubtractionCheck.cpp +++ b/clang-tools-extra/clang-tidy/abseil/TimeSubtractionCheck.cpp @@ -97,7 +97,7 @@ void TimeSubtractionCheck::registerMatchers(MatchFinder *Finder) { std::optional<DurationScale> Scale = getScaleForTimeInverse(TimeInverse); assert(Scale && "Unknown scale encountered"); - auto TimeInverseMatcher = callExpr(callee( + const auto TimeInverseMatcher = callExpr(callee( functionDecl(hasName((llvm::Twine("::absl::") + TimeInverse).str())) .bind("func_decl"))); @@ -106,7 +106,7 @@ void TimeSubtractionCheck::registerMatchers(MatchFinder *Finder) { // is not sufficient, since the second operand could be either a 'Time' or // a 'Duration'. If we know the result is a 'Duration', we can then infer // that the second operand must be a 'Time'. - auto CallMatcher = + const auto CallMatcher = callExpr( callee(functionDecl(hasName(getDurationFactoryForScale(*Scale)))), hasArgument(0, binaryOperator(hasOperatorName("-"), @@ -118,7 +118,7 @@ void TimeSubtractionCheck::registerMatchers(MatchFinder *Finder) { // Match cases where we know the second operand is a 'Time'. Since // subtracting a 'Time' from a 'Duration' is not defined, in these cases, // we always know the first operand is a 'Time' if the second is a 'Time'. - auto OperandMatcher = + const auto OperandMatcher = binaryOperator(hasOperatorName("-"), hasRHS(TimeInverseMatcher)) .bind("binop"); Finder->addMatcher(OperandMatcher, this); diff --git a/clang-tools-extra/clang-tidy/abseil/UncheckedStatusOrAccessCheck.cpp b/clang-tools-extra/clang-tidy/abseil/UncheckedStatusOrAccessCheck.cpp index 3dcdbd37e7795..c0e9b39144ea4 100644 --- a/clang-tools-extra/clang-tidy/abseil/UncheckedStatusOrAccessCheck.cpp +++ b/clang-tools-extra/clang-tidy/abseil/UncheckedStatusOrAccessCheck.cpp @@ -26,7 +26,7 @@ static constexpr StringRef FuncID = "fun"; void UncheckedStatusOrAccessCheck::registerMatchers(MatchFinder *Finder) { using namespace ast_matchers; - auto HasStatusOrCallDescendant = + const auto HasStatusOrCallDescendant = hasDescendant(callExpr(callee(cxxMethodDecl(ofClass(hasAnyName( "absl::StatusOr", "absl::internal_statusor::OperatorBase")))))); Finder->addMatcher( diff --git a/clang-tools-extra/clang-tidy/altera/IdDependentBackwardBranchCheck.cpp b/clang-tools-extra/clang-tidy/altera/IdDependentBackwardBranchCheck.cpp index 82a02dd6e9344..d33b6677b86b1 100644 --- a/clang-tools-extra/clang-tidy/altera/IdDependentBackwardBranchCheck.cpp +++ b/clang-tools-extra/clang-tidy/altera/IdDependentBackwardBranchCheck.cpp @@ -89,7 +89,7 @@ IdDependentBackwardBranchCheck::hasIdDepVar(const Expr *Expression) { dyn_cast_if_present<VarDecl>(Declaration->getDecl()); if (!CheckVariable) return nullptr; - auto FoundVariable = IdDepVarsMap.find(CheckVariable); + const auto FoundVariable = IdDepVarsMap.find(CheckVariable); if (FoundVariable == IdDepVarsMap.end()) return nullptr; return &(FoundVariable->second); @@ -111,7 +111,7 @@ IdDependentBackwardBranchCheck::hasIdDepField(const Expr *Expression) { dyn_cast_if_present<FieldDecl>(MemberExpression->getMemberDecl()); if (!CheckField) return nullptr; - auto FoundField = IdDepFieldsMap.find(CheckField); + const auto FoundField = IdDepFieldsMap.find(CheckField); if (FoundField == IdDepFieldsMap.end()) return nullptr; return &(FoundField->second); diff --git a/clang-tools-extra/clang-tidy/altera/SingleWorkItemBarrierCheck.cpp b/clang-tools-extra/clang-tidy/altera/SingleWorkItemBarrierCheck.cpp index c9df658d9bd67..22abf51c52879 100644 --- a/clang-tools-extra/clang-tidy/altera/SingleWorkItemBarrierCheck.cpp +++ b/clang-tools-extra/clang-tidy/altera/SingleWorkItemBarrierCheck.cpp @@ -54,7 +54,7 @@ void SingleWorkItemBarrierCheck::check(const MatchFinder::MatchResult &Result) { bool IsNDRange = false; if (MatchedDecl->hasAttr<ReqdWorkGroupSizeAttr>()) { const auto *Attribute = MatchedDecl->getAttr<ReqdWorkGroupSizeAttr>(); - auto Eval = [&](Expr *E) { + const auto Eval = [&](Expr *E) { return E->EvaluateKnownConstInt(MatchedDecl->getASTContext()) .getExtValue(); }; diff --git a/clang-tools-extra/clang-tidy/altera/StructPackAlignCheck.cpp b/clang-tools-extra/clang-tidy/altera/StructPackAlignCheck.cpp index 4a12a44bbbf79..36b4199d02e09 100644 --- a/clang-tools-extra/clang-tidy/altera/StructPackAlignCheck.cpp +++ b/clang-tools-extra/clang-tidy/altera/StructPackAlignCheck.cpp @@ -107,7 +107,7 @@ void StructPackAlignCheck::check(const MatchFinder::MatchResult &Result) { } FixItHint FixIt; - auto *Attribute = Struct->getAttr<AlignedAttr>(); + const auto *Attribute = Struct->getAttr<AlignedAttr>(); const std::string NewAlignQuantity = std::to_string(NewAlign.getQuantity()); if (Attribute) { FixIt = FixItHint::CreateReplacement( diff --git a/clang-tools-extra/clang-tidy/android/CloexecAccept4Check.cpp b/clang-tools-extra/clang-tidy/android/CloexecAccept4Check.cpp index 8cf22ba2acb4a..7f8616c1cddbd 100644 --- a/clang-tools-extra/clang-tidy/android/CloexecAccept4Check.cpp +++ b/clang-tools-extra/clang-tidy/android/CloexecAccept4Check.cpp @@ -14,9 +14,10 @@ using namespace clang::ast_matchers; namespace clang::tidy::android { void CloexecAccept4Check::registerMatchers(MatchFinder *Finder) { - auto SockAddrPointerType = + const auto SockAddrPointerType = hasType(pointsTo(recordDecl(isStruct(), hasName("sockaddr")))); - auto SockLenPointerType = hasType(pointsTo(namedDecl(hasName("socklen_t")))); + const auto SockLenPointerType = + hasType(pointsTo(namedDecl(hasName("socklen_t")))); registerMatchersImpl(Finder, functionDecl(returns(isInteger()), hasName("accept4"), diff --git a/clang-tools-extra/clang-tidy/android/CloexecAcceptCheck.cpp b/clang-tools-extra/clang-tidy/android/CloexecAcceptCheck.cpp index a624523b18137..216d97043ce32 100644 --- a/clang-tools-extra/clang-tidy/android/CloexecAcceptCheck.cpp +++ b/clang-tools-extra/clang-tidy/android/CloexecAcceptCheck.cpp @@ -14,9 +14,10 @@ using namespace clang::ast_matchers; namespace clang::tidy::android { void CloexecAcceptCheck::registerMatchers(MatchFinder *Finder) { - auto SockAddrPointerType = + const auto SockAddrPointerType = hasType(pointsTo(recordDecl(isStruct(), hasName("sockaddr")))); - auto SockLenPointerType = hasType(pointsTo(namedDecl(hasName("socklen_t")))); + const auto SockLenPointerType = + hasType(pointsTo(namedDecl(hasName("socklen_t")))); registerMatchersImpl(Finder, functionDecl(returns(isInteger()), hasName("accept"), diff --git a/clang-tools-extra/clang-tidy/android/CloexecCreatCheck.cpp b/clang-tools-extra/clang-tidy/android/CloexecCreatCheck.cpp index ae44efb629893..a43a0768c03f1 100644 --- a/clang-tools-extra/clang-tidy/android/CloexecCreatCheck.cpp +++ b/clang-tools-extra/clang-tidy/android/CloexecCreatCheck.cpp @@ -14,8 +14,8 @@ using namespace clang::ast_matchers; namespace clang::tidy::android { void CloexecCreatCheck::registerMatchers(MatchFinder *Finder) { - auto CharPointerType = hasType(pointerType(pointee(isAnyCharacter()))); - auto MODETType = hasType(namedDecl(hasName("mode_t"))); + const auto CharPointerType = hasType(pointerType(pointee(isAnyCharacter()))); + const auto MODETType = hasType(namedDecl(hasName("mode_t"))); registerMatchersImpl(Finder, functionDecl(isExternC(), returns(isInteger()), hasName("creat"), hasParameter(0, CharPointerType), diff --git a/clang-tools-extra/clang-tidy/android/CloexecFopenCheck.cpp b/clang-tools-extra/clang-tidy/android/CloexecFopenCheck.cpp index 8ddd6a0523156..06521f87119a3 100644 --- a/clang-tools-extra/clang-tidy/android/CloexecFopenCheck.cpp +++ b/clang-tools-extra/clang-tidy/android/CloexecFopenCheck.cpp @@ -14,7 +14,7 @@ using namespace clang::ast_matchers; namespace clang::tidy::android { void CloexecFopenCheck::registerMatchers(MatchFinder *Finder) { - auto CharPointerType = hasType(pointerType(pointee(isAnyCharacter()))); + const auto CharPointerType = hasType(pointerType(pointee(isAnyCharacter()))); registerMatchersImpl( Finder, functionDecl(isExternC(), returns(asString("FILE *")), hasName("fopen"), hasParameter(0, CharPointerType), diff --git a/clang-tools-extra/clang-tidy/android/CloexecMemfdCreateCheck.cpp b/clang-tools-extra/clang-tidy/android/CloexecMemfdCreateCheck.cpp index 5ecf908aabb59..97f20ee7f3310 100644 --- a/clang-tools-extra/clang-tidy/android/CloexecMemfdCreateCheck.cpp +++ b/clang-tools-extra/clang-tidy/android/CloexecMemfdCreateCheck.cpp @@ -13,7 +13,7 @@ using namespace clang::ast_matchers; namespace clang::tidy::android { void CloexecMemfdCreateCheck::registerMatchers(MatchFinder *Finder) { - auto CharPointerType = hasType(pointerType(pointee(isAnyCharacter()))); + const auto CharPointerType = hasType(pointerType(pointee(isAnyCharacter()))); registerMatchersImpl( Finder, functionDecl(returns(isInteger()), hasName("memfd_create"), hasParameter(0, CharPointerType), diff --git a/clang-tools-extra/clang-tidy/android/CloexecOpenCheck.cpp b/clang-tools-extra/clang-tidy/android/CloexecOpenCheck.cpp index 9938027c53b0e..7c70f1a71a79f 100644 --- a/clang-tools-extra/clang-tidy/android/CloexecOpenCheck.c... [truncated] `````````` </details> https://github.com/llvm/llvm-project/pull/213840 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
