xazax.hun accepted this revision.
xazax.hun added a comment.
Some minor nits otherwise LGTM!
================
Comment at: include/clang/Analysis/AnalysisDeclContext.h:479
+ /// Get a reference to {@code BodyFarm} instance.
+ BodyFarm& getBodyFarm();
----------------
The reference is on the wrong side.
================
Comment at: include/clang/Analysis/BodyFarm.h:43
+ /// Remove copy constructor to avoid accidental copying.
+ BodyFarm(const BodyFarm& other) = delete;
+
----------------
Reference is on the wrong side.
================
Comment at: lib/Analysis/AnalysisDeclContext.cpp:308
-BodyFarm *AnalysisDeclContextManager::getBodyFarm() {
- if (!FunctionBodyFarm)
- FunctionBodyFarm = llvm::make_unique<BodyFarm>(ASTCtx, Injector.get());
- return FunctionBodyFarm.get();
+BodyFarm& AnalysisDeclContextManager::getBodyFarm() {
+ return FunctionBodyFarm;
----------------
Same as above.
https://reviews.llvm.org/D39428
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
