hfinkel added inline comments.
================ Comment at: lib/Driver/Driver.cpp:706 + + // Determine architecture part of the file name, if it presents. + size_t ArchPrefixLen = 0; ---------------- if it presents. -> if it is present. ================ Comment at: lib/Driver/Driver.cpp:739 + // like: i386-clang.cfg -> x86_64-clang.cfg. + if (ArchPrefixLen < CfgFileName.size()) + FixedConfigFile += CfgFileName.substr(ArchPrefixLen); ---------------- I don't see how this length check makes sense in all cases. If CfgFileName came from a --config command-line options, whether or not it is longer or shoter than ArchPrefixLen seems irrelevant. Do you need to do some prefix check here? https://reviews.llvm.org/D24933 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
