https://github.com/cor3ntin commented:

I think i have the same comments as others, namely I think I'd like a more 
detailed description so that i understand the use cases.

Even if `__attribute(used)` isn't exactly what you need, an attribute form 
seems a lot more user-friendly and portable than a command line option.

Are you trying to emulate a flag that exist in another implementation?
You mentioned using `__attribute__((visibility("protected"))) 
__attribute__((weak))` downstream. 
Why not keep doing that or adding an attribute with the same semantics?

Why limit to character types? Lack of use cases?

And yes, if the only use case is identical to `#pragma copyright`, why both?

https://github.com/llvm/llvm-project/pull/187986
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to