NagyDonat wrote:

> @NagyDonat Could you please have a look at this and measure this change? 
> Looks correct to me but I want to be 100% sure it's actually good.

I started a CI run that analyzes a dozen open source projects with this 
revision (comparing it to its parent on the main branch).

The change LGTM overally if you follow the [the suggestion to add an 
assertion](https://github.com/llvm/llvm-project/pull/210649#discussion_r3614802560)
 and silence the windows-specific test failures (e.g. by pinning the target 
triple).

https://github.com/llvm/llvm-project/pull/210649
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to