thakis added a comment.
Can you build some large-ish codebase (say, LLVM) with and without this patch
and make sure that this doesn't measurably add to build perf? (With the warning
turned on, obviously.)
Other than that, this looks good to me.
================
Comment at: test/SemaCXX/warn-zero-nullptr.cpp:68
+ public:
+// FIXME: this one should *NOT* warn.
+ explicit TemplateClass1(int a, T default_value = 0) {} //
expected-warning{{zero as null pointer constant}} expected-warning{{zero as
null pointer constant}}
----------------
Did you mean to fix this before commit?
Repository:
rL LLVM
https://reviews.llvm.org/D38954
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
