https://github.com/steakhal commented:
This largely matches what I've been doing downstream except for a couple of things: We should break this down. Having this many lambdas is a signal for breaking things up. Also by looking at the length of the functions, same story. `getStringLiteralFromRegion` seems pretty complicated for what it fundamentally needs to do. I haven't checked if it's warranted complexity but it was surprising to see non the less. I think I'd like to see a better composition of the handlers because right now we funnel all of these APIs into some common handler, and then we match them back up to do the specific thing they need. I think I'd be curious to see how would this look like if we had specific handlers or a different abstraction layer. If you want, I can drop the branch I've been working on and guide you through - otherwise I'd prefer tackling this myself. https://github.com/llvm/llvm-project/pull/210154 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
