[clang-tools-extra] [clang-tidy] Extend bugprone-narrowing-conversions with time_t narrowing option (PR #209856)

[via cfe-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. 
:warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,h -- 
clang-tools-extra/test/clang-tidy/checkers/bugprone/narrowing-conversions-time-t.cpp
 clang-tools-extra/clang-tidy/bugprone/NarrowingConversionsCheck.cpp 
clang-tools-extra/clang-tidy/bugprone/NarrowingConversionsCheck.h 
--diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git 
a/clang-tools-extra/clang-tidy/bugprone/NarrowingConversionsCheck.cpp 
b/clang-tools-extra/clang-tidy/bugprone/NarrowingConversionsCheck.cpp
index 3310c9f77..ab69149a6 100644
--- a/clang-tools-extra/clang-tidy/bugprone/NarrowingConversionsCheck.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/NarrowingConversionsCheck.cpp
@@ -55,7 +55,8 @@ 
NarrowingConversionsCheck::NarrowingConversionsCheck(StringRef Name,
       WarnWithinTemplateInstantiation(
           Options.get("WarnWithinTemplateInstantiation", false)),
       WarnOnEquivalentBitWidth(Options.get("WarnOnEquivalentBitWidth", true)),
-      
WarnOnTimeTNarrowingConversion(Options.get("WarnOnTimeTNarrowingConversion", 
false)),
+      WarnOnTimeTNarrowingConversion(
+          Options.get("WarnOnTimeTNarrowingConversion", false)),
       IgnoreConversionFromTypes(Options.get("IgnoreConversionFromTypes", "")),
       PedanticMode(Options.get("PedanticMode", false)) {}
 
@@ -70,7 +71,8 @@ void NarrowingConversionsCheck::storeOptions(
   Options.store(Opts, "WarnWithinTemplateInstantiation",
                 WarnWithinTemplateInstantiation);
   Options.store(Opts, "WarnOnEquivalentBitWidth", WarnOnEquivalentBitWidth);
-  Options.store(Opts, "WarnOnTimeTNarrowingConversion", 
WarnOnTimeTNarrowingConversion);
+  Options.store(Opts, "WarnOnTimeTNarrowingConversion",
+                WarnOnTimeTNarrowingConversion);
   Options.store(Opts, "IgnoreConversionFromTypes", IgnoreConversionFromTypes);
   Options.store(Opts, "PedanticMode", PedanticMode);
 }
@@ -282,7 +284,6 @@ bool hasTimeTTypedef(QualType QT) {
 }
 
 bool exprMentionsTimeT(const Expr *E) {
-
   if (!E)
     return false;
 
@@ -457,8 +458,8 @@ void 
NarrowingConversionsCheck::diagTimeTConversion(SourceLocation SourceLoc,
       << getUnqualifiedType(Rhs) << getUnqualifiedType(Lhs);
 }
 
-void NarrowingConversionsCheck::handleTimeTOnlyCast(
-    const ASTContext &Context, const CastExpr &Cast) {
+void NarrowingConversionsCheck::handleTimeTOnlyCast(const ASTContext &Context,
+                                                    const CastExpr &Cast) {
   const Expr &Lhs = Cast;
   const Expr &Rhs = *Cast.getSubExprAsWritten();
 
@@ -469,9 +470,10 @@ void NarrowingConversionsCheck::handleTimeTOnlyCast(
   handleTimeTConversion(Context, SourceLoc, Lhs, Rhs);
 }
 
-void NarrowingConversionsCheck::handleTimeTConversion(
-  const ASTContext &Context, SourceLocation SourceLoc,
-  const Expr &Lhs, const Expr &Rhs) {
+void NarrowingConversionsCheck::handleTimeTConversion(const ASTContext 
&Context,
+                                                      SourceLocation SourceLoc,
+                                                      const Expr &Lhs,
+                                                      const Expr &Rhs) {
   if (!WarnOnTimeTNarrowingConversion)
     return;
 
@@ -756,7 +758,8 @@ void NarrowingConversionsCheck::check(const 
MatchFinder::MatchResult &Result) {
     handleBinaryOperator(*Result.Context, *Op);
   else if (const auto *Cast = Result.Nodes.getNodeAs<ImplicitCastExpr>("cast"))
     handleImplicitCast(*Result.Context, *Cast);
-  else if (const auto *ECast = 
Result.Nodes.getNodeAs<ExplicitCastExpr>("explicit_cast"))
+  else if (const auto *ECast =
+               Result.Nodes.getNodeAs<ExplicitCastExpr>("explicit_cast"))
     handleTimeTOnlyCast(*Result.Context, *ECast);
   else
     llvm_unreachable("must be binary operator or cast expression");

``````````

</details>


https://github.com/llvm/llvm-project/pull/209856
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits