erichkeane added inline comments.

================
Comment at: lib/AST/Type.cpp:2212-2213
+    for (const auto Base : ClassDecl->bases()) {
+      if (Base.isVirtual())
+        return false;
+
----------------
rnk wrote:
> OK, I guess vbases don't have a unique representation. :) What about vtable 
> slots? Should we check isDynamic?
Dynamic types are caught by "isTriviallyCopyable" pretty early in the process.  
I'll add a pair of tests to ensure that this remains the case.


https://reviews.llvm.org/D39064



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to