Ah, thanks for letting me know! I’ll do that now. From: tha...@google.com [mailto:tha...@google.com] On Behalf Of Nico Weber Sent: Tuesday, October 24, 2017 8:59 AM To: Keane, Erich <erich.ke...@intel.com> Cc: cfe-commits <cfe-commits@lists.llvm.org> Subject: Re: r316447 - Fix spelling in comment, field is isMsStruct, not Strust
This is fine, but a few years ago we agreed that we shouldn't repeat method names in doxygen. So an Even Better Fix would've been to just remove everything up to (and including) the ' - ' :-) Just FYI, no need to follow this up with the deletion. On Tue, Oct 24, 2017 at 3:34 PM, Erich Keane via cfe-commits <cfe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org>> wrote: Author: erichkeane Date: Tue Oct 24 08:34:59 2017 New Revision: 316447 URL: http://llvm.org/viewvc/llvm-project?rev=316447&view=rev Log: Fix spelling in comment, field is isMsStruct, not Strust Modified: cfe/trunk/include/clang/AST/Decl.h Modified: cfe/trunk/include/clang/AST/Decl.h URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/Decl.h?rev=316447&r1=316446&r2=316447&view=diff ============================================================================== --- cfe/trunk/include/clang/AST/Decl.h (original) +++ cfe/trunk/include/clang/AST/Decl.h Tue Oct 24 08:34:59 2017 @@ -3540,7 +3540,7 @@ public: return K >= firstRecord && K <= lastRecord; } - /// isMsStrust - Get whether or not this is an ms_struct which can + /// isMsStruct - Get whether or not this is an ms_struct which can /// be turned on with an attribute, pragma, or -mms-bitfields /// commandline option. bool isMsStruct(const ASTContext &C) const; _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits